Add Kubectl binary download script for all Linux distributions

[k37y]

Changes

Kubectl binary download script modification has been done to accommodate all Linux distributions.

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

Release Notes

NONE

[HeavyWombat]

Thanks for the PR. I do not know where other than the CI this script is being used, but having it more generic and supporting multiple Linux distributions is not a bad idea. However, I would opt for externalizing the logic. We should keep this brief and simple. If we were to start with the package manager switch, we could end up adding more and more cases that would need to be maintained.

For simplicity, I would suggest to adopt in the install kubectl with curl style.

[HeavyWombat]

This would be my suggestion:

#!/bin/bash

# Copyright The Shipwright Contributors
# 
# SPDX-License-Identifier: Apache-2.0

#
# Installs "kubectl"
#

set -euo pipefail

# Find a suitable install location
if [[ -w /usr/local/bin ]]; then
  TARGET_DIR=/usr/local/bin

elif [[ -w "${HOME}/bin" ]] && grep -q -e "${HOME}/bin" -e '\~/bin' <<<"$PATH"; then
  TARGET_DIR="${HOME}/bin"

else
  echo -e "Unable to determine a writable install location. Make sure that you have write access to either \\033[1m/usr/local/bin\\033[0m or \\033[1m${HOME}/bin\\033[0m and that is in your PATH."
  exit 1
fi

# Look-up current stable version from their release site
STABLE_VERSION="$(curl --fail --silent --location https://dl.k8s.io/release/stable.txt)"

echo "# Downloading kubectl binary..."
curl --fail --progress-bar --location "https://dl.k8s.io/release/${STABLE_VERSION}/bin/linux/amd64/kubectl" --output "${TARGET_DIR}/kubectl" && \
  chmod a+rx "${TARGET_DIR}/kubectl"

echo "# Validating kubectl binary..."
sha256sum --check <<<"$(curl --fail --silent --location "https://dl.k8s.io/${STABLE_VERSION}/bin/linux/amd64/kubectl.sha256") ${TARGET_DIR}/kubectl"

echo "# Kubectl version"
kubectl version --client

It is relatively short, requires no sudo and should run on most distros just fine. I checked it on Ubuntu, Fedora and UBI.

[k37y]

@HeavyWombat, It looks clean. I have made the suggested changes. Observed the same on shipwright-io/cli as well. Hence, shipwright-io/cli#31.

[HeavyWombat]

@kevydotvinu Could you help me by rebasing this branch to get the latest updates? I think there was a commit that addresses the deployment for the test cases.

[k37y]

@kevydotvinu Could you help me by rebasing this branch to get the latest updates? I think there was a commit that addresses the deployment for the test cases.

Yes, I have done that. Thanks, @HeavyWombat. :)

[HeavyWombat]

/lgtm

[SaschaSchwarze0]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [SaschaSchwarze0]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment