-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared Flags for Build and BuildRun #17
Shared Flags for Build and BuildRun #17
Conversation
Extending `flags` package to support Build and BuildRun objects, reusing shared flags among resources. Adding more tests and documentation.
/retitle Build and BuildRun Create Sub-commands |
/cc @alicerum |
/retitle [WIP] Build and BuildRun Create Sub-commands I'm going to have a look |
52a55d5
to
a903843
Compare
/retitle Shared Flags for Build and BuildRun |
/lgtm this is awesome, thanks :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly grammar nits and doc clean up comments. I really like the refactoring in this PR, this will help make the CLI more maintainable.
Extending `flags` package to support Build and BuildRun objects, reusing shared flags among resources. Adding more tests and documentation. Co-authored-by: Adam Kaplan <[email protected]>
06831f8
to
5fc9a64
Compare
Additionally making sure "build run" also uses the same machinery. Co-authored-by: Adam Kaplan <[email protected]>
5fc9a64
to
0548273
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Continue the work started on
flags
package to centralize all flag definitions in a single location, and using those onshp build create
,shp build run
andshp buildrun create
, so they all rely in the same flags.For instance:
Additionally, improving doc-comments and getting started with long-descriptions.