Fixing Pointer-to-String Flags and Improve Testing

[otaviof]

Changes

Refactoring the flags using string-to-pointer inside a nested structure to avoid StringPointerValue. Additionally, covering the flags package with unit-tests, every command-line flag is checked.

Fixes #26

Testing

Execute the following commands in order, so a new BuildRun object is created using a service-account named "test":

# first, create a new build
shp build create nodejs-ex --source-url="https://github.com/otaviof/nodejs-ex.git" # ...

# then, create a new build-run using service-account name option
shp buildrun create br --buildref-name=nodejs-ex --sa-name=test

# and, assert service-account name was issued
oc get buildruns.shipwright.io br -o json |jq '.spec.serviceAccount'

The last command should confirm the desired service-account is in place:

$ oc get buildruns.shipwright.io br -o json |jq '.spec.serviceAccount'
{
  "name": "test"
}

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

Release Notes

- Fixing command-line flags based on pointer-to-string, for instance "--sa-name"
- Adding tests to prevent comment-line flag issues in the future

[otaviof]

/cc @coreydaley

[otaviof]

/retitle Testing Flags

[gabemontero]

if we are fixing an issue @otaviof there really should be a release note

[gabemontero]

along with that, update the PR title to give some sort of hint that something is being fixed

[gabemontero]

otherwise cool stuff :-) !!

/approve

I'll lgtm once the PR title / release note are addressed.

Or I can hold off if one of the other reviewers here chimes in that they want to take a pass at this before it merges

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gabemontero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[otaviof]

along with that, update the PR title to give some sort of hint that something is being fixed

Thanks, @gabemontero, indeed when fixing the behavior it should be mentioned on the title and release-notes. Please consider.

[otaviof]

/retitle Fixing Pointer-to-String Flags and Improve Testing

[gabemontero]

thanks @otaviof

as I have not heard from anybody else on the team here wrt reviewing this soon, and it has been open for a week now, going to

/lgtm