Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove use of dynamic client; add tests with more reliable static clients #36

Merged
merged 4 commits into from
Jul 28, 2021

Conversation

gabemontero
Copy link
Member

Changes

Fixes #24

Before I go on PTO, I was able to make enough progress here to submit a PR for review while I'm out.

Among other things, I added some tests for buildrun cancel and logs that previously did not exist (in my recently merged cancel PR we talked about adding tests when we switched to static client).

The basic CRUD operations are probably OK without tests. Or they could be added by others after this PR merged. Or if insisted upon I could add them after I get back if this PR is still open.

The build run unit test would be a meatier one. Minimally verifying the generation of the build run. Really meaty if we took on log following and somehow included elements of the pod watcher unit tests.

/assign @otaviof
/assign @coreydaley

@adambkaplan @alicerum @HeavyWombat FYI

/kind cleanup

Submitter Checklist

  • [ Y] Includes tests if functionality changed/was added
  • [ n/a ] Includes docs if changes are user-facing
  • [ Y] Set a kind label on this PR
  • [ Y] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

switch from dynamic k8s client to static k8s and shipwright clients

@openshift-ci openshift-ci bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 26, 2021
@openshift-ci openshift-ci bot requested review from HeavyWombat and otaviof July 26, 2021 22:57
@gabemontero
Copy link
Member Author

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2021
Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
@openshift-merge-robot openshift-merge-robot merged commit c8174b4 into shipwright-io:main Jul 28, 2021
@gabemontero gabemontero deleted the no-dyn-client branch July 31, 2021 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review the Need for the Dynamic-Client
5 participants