Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate buildrun logs command #65

Conversation

SaschaSchwarze0
Copy link
Member

Changes

When running shp buildrun help, then the logs subcommand was listed twice:

$ shp buildrun help
Manage BuildRuns

Usage:
  shp buildrun [flags]
  shp buildrun [command]

Aliases:
  buildrun, br

Available Commands:
  cancel      Cancel BuildRun
  create      Creates a BuildRun instance.
  list        List Builds
  logs        See BuildRun log output
  logs        See BuildRun log output

[...]

Fixing this.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

`shp buildrun help` now only lists the logs sub-command once rather than twice

@SaschaSchwarze0 SaschaSchwarze0 added the kind/bug Categorizes issue or PR as related to a bug. label Oct 27, 2021
@openshift-ci openshift-ci bot requested review from imjasonh and sbose78 October 27, 2021 18:07
@gabemontero
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2021
@openshift-merge-robot openshift-merge-robot merged commit 58bf59b into shipwright-io:main Oct 28, 2021
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-remove-duplicate-logs branch November 9, 2021 10:21
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.7.0 milestone Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants