Bump to latest Shipwright #8
Conversation
Update modules and vendor
Modify to use the new field names.
qu1queee
force-pushed
the
qu1queee/bump_modules
branch
from
e4649f2 to
4b40a50
Compare
|
@alicerum pls take a look, we need this for cli to be compatible with latest changes upstream in build. |
| github.com/pkg/errors v0.9.1 | ||
| github.com/shipwright-io/build v0.3.0 | ||
| github.com/shipwright-io/build v0.3.1-0.20210330182238-23d2672f2f61 |
There was a problem hiding this comment.
For CLI, do we want to follow nightly in our main branch and only depend on releases when we release CLI?
@adambkaplan @otaviof @qu1queee
|
/lgtm i'm not sure whether we want to wait for |
|
@qu1queee you may need to rebase this PR to get the OWNERS file updated (without it the CI bot doesn't work right) |
|
openshift/release#17632 should fix the merge issue. Note this needs the "approve" label. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Going to "green button" this, need to fix one more thing before we get the tide automation working. |
This is required so that someone deploying Shipwright/Build from
masterbranch can have compatibility with the resources generated from Shipwright/CLI.At the moment CLI points to the Shipwright/Build version with the old group
build.dev, while the latest Shipwright/Build usesshipwright.ioI struggle a lot doing this bump due to an issue with the
kustomizedependency. Thego.modneeds to ping a dependency due to some indirect dependencies in knative side that comes when bumping the shipwright/build module.