Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for riscv64 FreeBSD #1425

Open
clausecker opened this issue Mar 2, 2023 · 4 comments
Open

Missing support for riscv64 FreeBSD #1425

clausecker opened this issue Mar 2, 2023 · 4 comments

Comments

@clausecker
Copy link

The package is missing support code for riscv64 FreeBSD. Please add such code:

# github.com/shirou/gopsutil/disk                          
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:108:39: undefined: sizeOfDevstat                                
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:113:14: undefined: sizeOfDevstat                                
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:126:29: undefined: DEVSTAT_READ                                 
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:127:29: undefined: DEVSTAT_WRITE                                
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:128:24: undefined: DEVSTAT_READ                                 
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:129:24: undefined: DEVSTAT_WRITE                                
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:130:34: undefined: DEVSTAT_READ                                 
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:131:34: undefined: DEVSTAT_WRITE                                
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:141:9: undefined: Bintime                                       
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:148:32: undefined: Devstat                                      
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:131:34: too many errors   
@Lomanic
Copy link
Collaborator

Lomanic commented Mar 2, 2023

If you have a riscv64 FreeBSD host with a Go compiler, please run mktypes.sh and open a merge request with the generated files.

@clausecker
Copy link
Author

The script doesn't run when executed on a freshly cloned checkout.

$ sh mktypes.sh 
/home/fuz/src/gopsutil/host/types_freebsd.go:15:10: fatal error: 'freebsd_headers/utxdb.h' file not found
#include "freebsd_headers/utxdb.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
cd: v3: No such file or directory

@Lomanic
Copy link
Collaborator

Lomanic commented Mar 2, 2023

Thanks for trying, if you apply the following patch, is the script now running properly? issue1425.diff.txt

@clausecker
Copy link
Author

Nope, no difference. A v3 directory doesn't exist either.

$ CFLAGS=-I./home/fuz/src/gopsutil/host sh mktypes.sh
/home/fuz/src/gopsutil/host/types_freebsd.go:15:10: fatal error: 'utxdb.h' file not found
#include "utxdb.h"
         ^~~~~~~~~
1 error generated.
cd: v3: No such file or directory

clausecker added a commit to clausecker/gopsutil that referenced this issue May 18, 2024
This makes mktypes.sh succeed on FreeBSD.

For shirou#1425
clausecker added a commit to clausecker/gopsutil that referenced this issue May 18, 2024
Generated on 15-CURRENT 5d62025d82a0.

Fixes shirou#1425.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants