chore: enable unused-parameter from revive #1783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
force-pushed
the
revive/unused-parameter
branch
from
0f0c11c to
d41f983
Compare
github-actions
bot
added
package:host
package:process
package:disk
package:docker
package:net
labels
mmorel-35
force-pushed
the
revive/unused-parameter
branch
2 times, most recently
from
ccce57b to
f672dca
Compare
mmorel-35
force-pushed
the
revive/unused-parameter
branch
2 times, most recently
from
2689660 to
053af0b
Compare
mmorel-35
force-pushed
the
revive/unused-parameter
branch
3 times, most recently
from
c4715fe to
051a2fe
Compare
|
@shirou , |
|
I have opened #1797 , I believ it's better to merge it first and then update this one. |
mmorel-35
force-pushed
the
revive/unused-parameter
branch
8 times, most recently
from
ca659f4 to
35e8062
Compare
mmorel-35
force-pushed
the
revive/unused-parameter
branch
from
35e8062 to
37dd0eb
Compare
mmorel-35
force-pushed
the
revive/unused-parameter
branch
4 times, most recently
from
a96c3b6 to
103801b
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
revive/unused-parameter
branch
from
103801b to
1f43ea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
unused-parameter: This rule warns on unused parameters. Functions or methods with unused parameters can be a symptom of an unfinished refactoring or a bug.