refactor: Containerfile+Makefile improvement: build crates together, then distribute the binaries #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaro00
force-pushed
the
fix/docker-caching
branch
from
581c0f6 to
aa8bff2
Compare
jonaro00
force-pushed
the
fix/docker-caching
branch
from
0635059 to
d7d4926
Compare
chesedo
reviewed
Aug 21, 2023
oddgrd
reviewed
Aug 21, 2023
jonaro00
force-pushed
the
fix/docker-caching
branch
from
ff59b04 to
5385189
Compare
orhun
reviewed
Aug 21, 2023
jonaro00
force-pushed
the
fix/docker-caching
branch
from
5385189 to
66a7d2c
Compare
oddgrd
reviewed
Aug 22, 2023
orhun
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
How has this been tested? (if applicable)
USE_PANAMAX=disable make imageswith debug mode now takes less than 10min from scratch (used to take >20min). Can still be improved a lot by improvements to cargo-chef.