Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE when count() AttributeFunction is used #1485

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

tishan89
Copy link
Contributor

@tishan89 tishan89 commented Sep 3, 2019

Purpose

Fix wso2/product-sp#1039

Security checks

@codecov-io
Copy link

Codecov Report

Merging #1485 into master will decrease coverage by 0.02%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1485      +/-   ##
============================================
- Coverage     68.13%   68.11%   -0.03%     
  Complexity       42       42              
============================================
  Files           643      643              
  Lines         26967    26968       +1     
  Branches       4256     4257       +1     
============================================
- Hits          18375    18370       -5     
- Misses         6803     6806       +3     
- Partials       1789     1792       +3
Impacted Files Coverage Δ Complexity Δ
...io/siddhi/core/table/record/ExpressionBuilder.java 56.47% <80%> (-0.23%) 0 <0> (ø)
...c/main/java/io/siddhi/core/util/ThreadBarrier.java 80% <0%> (-20%) 0% <0%> (ø)
...istence/IncrementalFileSystemPersistenceStore.java 50.96% <0%> (-1.93%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9afc84...edca2b0. Read the comment docs.

@mohanvive mohanvive merged commit 3df5ee2 into siddhi-io:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when accessing login sessions in Analytics Dashboard
3 participants