Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE when stream name is use to reference attributes in agg query #1497

Merged
merged 6 commits into from
Sep 16, 2019
Merged

Fix NPE when stream name is use to reference attributes in agg query #1497

merged 6 commits into from
Sep 16, 2019

Conversation

niveathika
Copy link
Member

@niveathika niveathika commented Sep 10, 2019

Purpose

$subject, fixes #1494

Documentation

N/A

Security checks

@codecov-io
Copy link

codecov-io commented Sep 10, 2019

Codecov Report

Merging #1497 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1497      +/-   ##
============================================
- Coverage     68.15%   68.15%   -0.01%     
  Complexity       42       42              
============================================
  Files           643      643              
  Lines         26981    26984       +3     
  Branches       4260     4260              
============================================
  Hits          18390    18390              
- Misses         6805     6808       +3     
  Partials       1786     1786
Impacted Files Coverage Δ Complexity Δ
...core/aggregation/AggregationExpressionVisitor.java 25.68% <100%> (ø) 0 <0> (ø) ⬇️
...io/siddhi/core/aggregation/AggregationRuntime.java 52.64% <46.66%> (+1.14%) 0 <0> (ø) ⬇️
...c/main/java/io/siddhi/core/util/ThreadBarrier.java 80% <0%> (-20%) 0% <0%> (ø)
.../siddhi/core/util/event/handler/StreamHandler.java 62% <0%> (-12%) 0% <0%> (ø)
...istence/IncrementalFileSystemPersistenceStore.java 50.96% <0%> (-0.97%) 0% <0%> (ø)
...i/core/util/parser/CollectionExpressionParser.java 39.51% <0%> (+0.43%) 0% <0%> (ø) ⬇️
...java/io/siddhi/core/stream/input/InputHandler.java 80.64% <0%> (+3.22%) 0% <0%> (ø) ⬇️
.../collection/executor/AnyAndCollectionExecutor.java 29.62% <0%> (+3.7%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13aa691...0f8e667. Read the comment docs.

@mohanvive mohanvive merged commit c39d310 into siddhi-io:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE when using stream name to refer to attributes in aggregation join queries
4 participants