Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE being thrown intermittently while removing bundles in shutdown process #1541

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

pcnfernando
Copy link
Contributor

Purpose

Fixes #1540

@niveathika niveathika merged commit 2f0e800 into siddhi-io:master Oct 9, 2019
@codecov-io
Copy link

Codecov Report

Merging #1541 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1541      +/-   ##
============================================
- Coverage     67.93%   67.89%   -0.04%     
  Complexity       45       45              
============================================
  Files           648      648              
  Lines         27313    27315       +2     
  Branches       4296     4297       +1     
============================================
- Hits          18554    18545       -9     
- Misses         6965     6971       +6     
- Partials       1794     1799       +5
Impacted Files Coverage Δ Complexity Δ
...ava/io/siddhi/core/util/SiddhiExtensionLoader.java 46.66% <0%> (-0.71%) 0 <0> (ø)
.../siddhi/core/util/event/handler/StreamHandler.java 62% <0%> (-12%) 0% <0%> (ø)
...java/io/siddhi/core/stream/input/InputHandler.java 69.44% <0%> (-5.56%) 0% <0%> (ø)
...ut/stream/state/AbsentStreamPreStateProcessor.java 85.51% <0%> (-1.38%) 0% <0%> (ø)
...o/siddhi/core/aggregation/IncrementalExecutor.java 80.46% <0%> (-0.79%) 0% <0%> (ø)
.../io/siddhi/core/util/snapshot/SnapshotService.java 71.22% <0%> (+0.41%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b68c3...eb48dbb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE when bundle unloads when SiddhiManager shutdown
4 participants