Disable light client when fork epoch is misaligned #7022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eserilev
added
ready-for-review
eserilev
changed the title
eserilev
changed the title
eserilev
added
work-in-progress
eserilev
added
ready-for-review
|
Oops, looks like you merged |
|
A |
eserilev
force-pushed
the
light-client-gossip-failure-metrics
branch
from
4fa7acc to
cedc381
Compare
|
lol thanks, apparently my subconscious needs to merge unstable |
|
I got scared by the size of the diff 😱 . Now it's fixed I can review 😌 |
jimmygchen
reviewed
Feb 24, 2025
| LightClientFinalityUpdateError::Disabled | ||
| | LightClientFinalityUpdateError::TooLate => debug!( | ||
| self.log, | ||
| ":ight client finality update ignored"; |
There was a problem hiding this comment.
Suggested change
| ":ight client finality update ignored"; | |
| "Light client finality update ignored"; |
jimmygchen
reviewed
Feb 24, 2025
| &self, | ||
| current_slot: Slot, | ||
| ) -> bool { | ||
| let is_fork_boundary_inside_sync_committee_period = |fork_epoch: Epoch| { |
There was a problem hiding this comment.
There's an existing check below, but it only log a warning if it's misaligned. Perhaps we can remove that one given that it would be a bit more obvious now if the fork schedule is misaligned? (light client disabled)
lighthouse/beacon_node/src/lib.rs
Line 190 in a1b7d61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7002
Temporarily disables light client functionality when fork epoch is misaligned
Add metrics for Light client gossip verification failures. I've added two categories of errors
FailuresandIgnoresso we can differentiate between "real" failures and janky data. I've also added a new error typeTooLateso that we dont include stale data as part of our "Failures" metrics. Ideally it'd be nice to have this included in the 7.0 release