Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update marked to resolve CVE-2022-21681 #113

Closed
wants to merge 2 commits into from
Closed

Update marked to resolve CVE-2022-21681 #113

wants to merge 2 commits into from

Conversation

humble-barnacle001
Copy link

@humble-barnacle001 humble-barnacle001 commented Jan 20, 2022

$ npm -v
6.14.15
$ node -v
v12.22.9

@simonhaenisch
Copy link
Owner

Wrong lockfile version but thanks for the PR and issue!

@humble-barnacle001
Copy link
Author

Thanks for the release @simonhaenisch.

I have a suggestion regarding the lockfileVersion in package-lock.json: since the line https://github.com/simonhaenisch/md-to-pdf/blob/master/package.json#L17 mentions "engines": {"node": ">=12.0"}, and as per https://docs.npmjs.com/cli/v8/configuring-npm/package-lock-json#lockfileversion npm v6 (compatible with node v12.x) should use lockfileVersion: 1

@simonhaenisch
Copy link
Owner

npm 8 is also compatible with Node 12.

@humble-barnacle001
Copy link
Author

npm 8 is also compatible with Node 12.

Yes but suppose we install node 12 then by default we get npm v6 which requires version 1. As per the requirements, we install node v12 only as there is no mention of npm version so we assume that we have to support the default version of npm too

@simonhaenisch
Copy link
Owner

The package-lock is not part of what gets packed, i. e. doesn't exist when installing the package from npm. Thus it's only relevant for development, whereas the engines field in package.json is relevant for runtime compatibility.

@humble-barnacle001
Copy link
Author

The package-lock is not part of what gets packed, i. e. doesn't exist when installing the package from npm. Thus it's only relevant for development, whereas the engines field in package.json is relevant for runtime compatibility.

Ohh ok thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: There are a High Vulnerability on marked dependences
2 participants