Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for static type error for ow.object.valuesOfType() #185

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Fix for static type error for ow.object.valuesOfType() #185

merged 2 commits into from
Sep 30, 2020

Conversation

ilkerceng
Copy link
Contributor

@ilkerceng ilkerceng commented Sep 13, 2020 •
edited by sindresorhus
Loading

Fixes #181

@sindresorhus
Copy link
Owner

Can you add one or more tests?

@ilkerceng
Copy link
Contributor Author

Meanwhile, i think validate and addValidator functions which are implemented in Predicate class can also be declared in BasePredicate interface

@sindresorhus
Copy link
Owner

Meanwhile, i think validate and addValidator functions which are implemented in Predicate class can also be declared in BasePredicate interface

You are probably right about that. PR welcome for that.

@sindresorhus sindresorhus changed the title Fix for Static type error for ow.object.valuesOfType() for #181 Fix for static type error for ow.object.valuesOfType() Sep 30, 2020
@sindresorhus sindresorhus merged commit b3c5fbd into sindresorhus:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Static type error for ow.object.valuesOfType()
2 participants
@ilkerceng @sindresorhus