Clear existing timeouts when an abort signal aborts #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, running the following code would show the error being logged, but the process would only exist after 5 seconds (the value being passed as
milliseconds
):This happens because the
setTimeout
call (see here) isn't cleared when a signal has been passed and then aborted. This ongoing timeout can cause Node to hang until it's finished (if it's the only thing holding it from closing).This PR fixes this by cleaning up the timers not only after the promise has finished, but after
p-timeout
's own promise finishes, which includes possibly rejecting because of an abort signal.