-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spatial updates to the abstract spec #223
Open
jp-dark
wants to merge
14
commits into
main
Choose a base branch
from
dark/sc-50267/spatial-abstract-spec
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+112
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb7c888
to
099c3a5
Compare
fa16456
to
cf3d28c
Compare
ktsitsi
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIAC looks good to me!
johnkerl
approved these changes
Oct 21, 2024
ea46550
to
29024f9
Compare
29024f9
to
44a46a5
Compare
Add the following new datatypes to the abstract specification * `SOMAScene` * `SOMAPointCloud` * `SOMAGeometryDataFrame` * `SOMAMultiscaleImage`
Add `SOMAScene` and `SOMAMultiscaleImage` subsections with "TODO" comments.
Save those additions for a second PR.
Co-authored-by: John Kerl <[email protected]>
44a46a5
to
d6cbebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following new types are added:
The composite datatypes
SOMAExperiment
andSOMAMeasurement
are modified to include new spatial components. Details regarding the operations on these new types will be left to a future PR.