Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace STRING::string() by c_str() #197

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

bertsky
Copy link
Contributor

@bertsky bertsky commented Sep 25, 2019

As of tesseract-ocr/tesseract@cb0c024, Tesseract's API changed. This adapts to that change. I am not at all sure how to check this still builds older Tesseract versions, though. Help is appreciated.

Copy link
Contributor

@stweil stweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit tesseract-ocr/tesseract@4d514d5 added STRING::c_str as an alias for STRING::string in 2013, so it should be available in all relevant versions of Tesseract.

The latest Tesseract code (Git master) removed STRING::string.

That means the commit here should work with all current versions and is required for the latest Tesseract code.

@sirfz sirfz merged commit 417425d into sirfz:master Sep 25, 2019
@stweil
Copy link
Contributor

stweil commented Sep 25, 2019

Thank you, @bertsky and @sirfz.

Additional changes will be required in the future because I plan to remove the file strngs.h and the proprietary STRING class from the Tesseract API. It will be replaced either by std::string or by char*.

@sirfz
Copy link
Owner

sirfz commented Sep 25, 2019

Thanks for the info, we should be able to handle that without breaking compatibility for older versions. Please let us know once this change is pushed.

@stweil
Copy link
Contributor

stweil commented Oct 19, 2019

@sirfz, it would help to have a tagged release with this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants