#23 - don't slot empty or whitespace-only text nodes

skatejs · Mar 31, 2016 · 261010c · 261010c
1 parent 455147c
commit 261010c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/index.js b/src/index.js
@@ -143,6 +143,11 @@ function slotNodeIntoSlot (slot, node, insertBefore) {
   const assignedNodes = slot.getAssignedNodes();
   const slotInsertBeforeIndex = assignedNodes.indexOf(insertBefore);
 
+  // Don't slot empty text nodes. This messes up fallback content.
+  if (node.nodeType === 3 && node.textContent.trim().length === 0) {
+    return;
+  }
+
   nodeToSlotMap.set(node, slot);
 
   // If there's currently no assigned nodes, there will be, so remove all fallback content.

diff --git a/test/unit/slot/fallback-content.js b/test/unit/slot/fallback-content.js
@@ -48,6 +48,13 @@ describe('fallback-content', function () {
       expect(slot.____isInFallbackMode).to.equal(true);
     });
 
+    it('should not slot text nodes that are empty or have only whitespace', function () {
+      host.appendChild(document.createTextNode(''));
+      host.appendChild(document.createTextNode(' '));
+      host.appendChild(document.createTextNode('\n'));
+      expect(slot.getAssignedNodes().length).to.equal(0);
+    });
+
     describe('when assigned nodes', function () {
       let newNode;