fix(cli): support attributes of DynamoDB Tables for hotswapping

Fixes aws#19421
skinny85 · Mar 29, 2022 · 4b37410 · 4b37410
1 parent 6eb775e
commit 4b37410
Show file tree

Hide file tree

Showing 2 changed files with 80 additions and 0 deletions.
diff --git a/packages/aws-cdk/lib/api/evaluate-cloudformation-template.ts b/packages/aws-cdk/lib/api/evaluate-cloudformation-template.ts
@@ -360,6 +360,7 @@ const RESOURCE_TYPE_ATTRIBUTES_FORMATS: { [type: string]: { [attribute: string]:
     // the name attribute of the EventBus is the same as the Ref
     Name: parts => parts.resourceName,
   },
+  'AWS::DynamoDB::Table': { Arn: stdSlashResourceArnFmt },
   'AWS::AppSync::GraphQLApi': { ApiId: appsyncGraphQlApiApiIdFmt },
 };
 

diff --git a/packages/aws-cdk/test/api/hotswap/state-machine-hotswap-deployments.test.ts b/packages/aws-cdk/test/api/hotswap/state-machine-hotswap-deployments.test.ts
@@ -558,3 +558,82 @@ test('knows how to handle attributes of the AWS::Events::EventBus resource', asy
     }),
   });
 });
+
+test('knows how to handle attributes of the AWS::DynamoDB::Table resource', async () => {
+  // GIVEN
+  setup.setCurrentCfnStackTemplate({
+    Resources: {
+      Table: {
+        Type: 'AWS::DynamoDB::Table',
+        Properties: {
+          KeySchema: [{
+            AttributeName: 'name',
+            KeyType: 'HASH',
+          }],
+          AttributeDefinitions: [{
+            AttributeName: 'name',
+            AttributeType: 'S',
+          }],
+          BillingMode: 'PAY_PER_REQUEST',
+        },
+      },
+      Machine: {
+        Type: 'AWS::StepFunctions::StateMachine',
+        Properties: {
+          DefinitionString: '{}',
+          StateMachineName: 'my-machine',
+        },
+      },
+    },
+  });
+  setup.pushStackResourceSummaries(
+    setup.stackSummaryOf('Table', 'AWS::DynamoDB::Table', 'my-dynamodb-table'),
+  );
+  const cdkStackArtifact = setup.cdkStackArtifactOf({
+    template: {
+      Resources: {
+        Table: {
+          Type: 'AWS::DynamoDB::Table',
+          Properties: {
+            KeySchema: [{
+              AttributeName: 'name',
+              KeyType: 'HASH',
+            }],
+            AttributeDefinitions: [{
+              AttributeName: 'name',
+              AttributeType: 'S',
+            }],
+            BillingMode: 'PAY_PER_REQUEST',
+          },
+        },
+        Machine: {
+          Type: 'AWS::StepFunctions::StateMachine',
+          Properties: {
+            DefinitionString: {
+              'Fn::Join': ['', [
+                '{"TableName":"',
+                { Ref: 'Table' },
+                '","TableArn":"',
+                { 'Fn::GetAtt': ['Table', 'Arn'] },
+                '"}',
+              ]],
+            },
+            StateMachineName: 'my-machine',
+          },
+        },
+      },
+    },
+  });
+
+  // THEN
+  const result = await hotswapMockSdkProvider.tryHotswapDeployment(cdkStackArtifact);
+
+  expect(result).not.toBeUndefined();
+  expect(mockUpdateMachineDefinition).toHaveBeenCalledWith({
+    stateMachineArn: 'arn:aws:states:here:123456789012:stateMachine:my-machine',
+    definition: JSON.stringify({
+      TableName: 'my-dynamodb-table',
+      TableArn: 'arn:aws:dynamodb:here:123456789012:table/my-dynamodb-table',
+    }),
+  });
+});