This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Implement a strategy for stale containers #20
Comments
This also manifests itself in tests. If we stop a running test suite (Ctrl-C), it might happen that there are still containers left around, because they were created but never started. So when the tests run the next time, A solution might be the following:
I'm not quite sure about the 2nd point. |
After some discussion, perhaps the simplest solution would be to remove the container if it exists. |
dtheodor
added a commit
that referenced
this issue
May 11, 2018
dtheodor
added a commit
that referenced
this issue
May 14, 2018
dtheodor
added a commit
that referenced
this issue
May 14, 2018
dtheodor
added a commit
that referenced
this issue
May 14, 2018
dtheodor
added a commit
that referenced
this issue
May 14, 2018
dtheodor
added a commit
that referenced
this issue
May 14, 2018
dtheodor
added a commit
that referenced
this issue
May 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Right now, we remove containers in
StartContainer()
after they run successfully. However, it might happen, for example in case of a mistry failure while a container was running (eg.SIGKILL
), that containers are left around with nobody to remove them.We should decide on how to treat such cases.
The text was updated successfully, but these errors were encountered: