configurePickerView for ActionSheetCustomPicker throws exception

[yannify]

I think you want:

if (self.initialSelections.count > 0)

instead of:

if (self.initialSelections)

or only initialize the array in the initWithTitle method if intialSelections is not nill:

    if(initialSelections != nil)
    {
       self.initialSelections = [[NSArray alloc] initWithArray:initialSelections];
    }

[DoctorG]

It's the same thing

Sent from my iPhone 5s

On Jul 19, 2014, at 1:49 PM, Yanni Mitis [email protected] wrote:

I think you want:

if (self.initialSelections.count > 0)

instead of:

if (self.initialSelections)

or only initialize the array in the initWithTitle method if intialSelections is not nill:

if(initialSelections != nil)
{
   self.initialSelections = [[NSArray alloc] initWithArray:initialSelections];
}

—
Reply to this email directly or view it on GitHub.

[yannify]

How is it the same thing?

The way its currenltly written:

if(self.initializeSelections)

Will always evaluate to true, then the asserts within the if block will
fail if the initializeSelections array has a count of zero.

...
Actually, probably want:

if (self.initialSelections && self.initialSelections.count > 0)

to be safer.

On Sat, Jul 19, 2014 at 10:58 AM, Gregory P. Moore, MD <
[email protected]> wrote:

It's the same thing

Sent from my iPhone 5s

On Jul 19, 2014, at 1:49 PM, Yanni Mitis [email protected]
wrote:

I think you want:

if (self.initialSelections.count > 0)

instead of:

if (self.initialSelections)

or only initialize the array in the initWithTitle method if
intialSelections is not nill:

if(initialSelections != nil)
{
self.initialSelections = [[NSArray alloc]
initWithArray:initialSelections];
}
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#10 (comment)
.

[skywinder]

Hi.
It really is not so obvious what the correct behavior for this method.
And after your discussion I implement a batch of tests to cover most of all behaviours a4ec3ec & 2c5cb46.

What for this check?
I this, that check if (self.initialSelections && self.initialSelections.count > 0) need only if we want to ignore empty arrays. (like @[]).

Now the logic is: initialSelections.count must be equal to numberOfComponents in picker view.
But nil option is valid (set all components to 0 by default).

We already have initialiser without initialSelections
- (id)initWithTitle:delegate:showCancelButton:origin: and you can also set initalSections to nil.

So, I don't think that accept empty arrays is correct.

It's not clear, what behaviour is right.
I'm ready to discuss this.

[yannify]

This works as expected, thanks for the quick fix!

I think this is the correct behavior, if you call showPickerWithTitle and do not pass initialSelections: i.e.

• (id)showPickerWithTitle:(NSString *)title delegate:(id )delegate showCancelButton:(BOOL)showCancelButton origin:(id)origin
  {
  return [self showPickerWithTitle:title delegate:delegate showCancelButton:showCancelButton origin:origin
  initialSelections:nil ];
  }

then it should NOT instantiate an NSArray and assign it to self.initialSelections. i.e. the fix:

• (id)initWithTitle:(NSString *)title delegate:(id )delegate showCancelButton:(BOOL)showCancelButton origin:(id)origin initialSelections:(NSArray *)initialSelections
  {
  ...
  if (initialSelections)
  self.initialSelections = [[NSArray alloc] initWithArray:initialSelections];
  ...
  }

Thanks!