Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss action sheet by tapping on background #80

Closed
jklp opened this issue Oct 21, 2014 · 3 comments
Closed

Dismiss action sheet by tapping on background #80

jklp opened this issue Oct 21, 2014 · 3 comments

Comments

@jklp
Copy link

jklp commented Oct 21, 2014

The standard action sheet (UIActionSheet) has a behaviour whereby if you tap on the background (which is not the action sheet), it dismisses the sheet. I think the same thing should occur for this library too.

To implement, I put a tap recogniser on the window in the SWActionSheet class to detect the tap, but that seems a little messy, and was thinking there must be a cleaner way to do it - thoughts?

Thanks
Jerrold

@skywinder
Copy link
Owner

Hi.
I think it is right way to implement this behaviour.
But I check UIActionSheet and it not dismissing by the tap on background

@skywinder
Copy link
Owner

@jklp my mistake - it really closing by tap outside.
As I understood from your meassage - you already implement this feature
I'll be glad to review your pull-request with this feature.

anas-ambri added a commit to guestful/ActionSheetPicker-3.0 that referenced this issue Oct 27, 2014
…taps. This also permits dismissing the action sheet when clicking on the background. The check for which view has been clicked is pretty rudimentary, so I would be interested if someone can come up with something better. Closes skywinder#80
@skywinder skywinder reopened this Feb 13, 2015
@skywinder
Copy link
Owner

Hey, @jklp this feature implemented in #140 and will be merged soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants