Fix Swift Bug RE self.initialSelection in multi-pickers #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Swift, having self.initialSelection as (nonatomic, assign) resulted in EXC_BAD_ACCESS when initializing the picker and attempting to access the property. Changing to (nonatomic, strong) fixed the error.
Same issue as in MultiPicker
|
OMG, what a shame bug! |
skywinder
added a commit
that referenced
this pull request
Feb 8, 2016
Fix Swift Bug RE self.initialSelection in multi-pickers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected file: ActionSheetMultipleStringPicker.m
Affected variable: self.initialSelection - marked as (nonatomic, assign) NSArray *
Issue: In a Swift project, when I create an instance with:
let multiPicker = ActionSheetMultipleStringPicker(title: "", rows: [["Test"], ["Test"]], initialSelection: [0,0], doneBlock: nil, cancelBlock: nil, origin: self)The result is a crash with message EXC_BAD_ACCESS when ActionSheetMultipleStringPicker.m attempts to access self.initialSelection and enumerate through it.
Resolution: Change assign -> strong for self.initialSelection
This resolves the issue.