Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding warning to MaterialProperties for invalid keyword args #258

Merged
merged 6 commits into from
Oct 5, 2023

Conversation

timryanb
Copy link
Collaborator

@timryanb timryanb commented Oct 5, 2023

  • Since PR Making it easier to define orthotropic properties using MaterialProperties class #252 , invalid input args being passed to MaterialProperties change the default material type to orthotropic
  • This can have unexpected behavior for users who accidentally misspell valid isotropic parameters
  • To make the issue clearer the following changes have been made:
    1. Passing an invalid/misspelled argument raises an explicit warning
    2. Invalid arguments are ignored when deciding if the properties are orthtropic/isotropic

@A-CGray A-CGray merged commit 87f8e98 into smdogroup:master Oct 5, 2023
@timryanb timryanb deleted the mat_prop_warning branch October 5, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants