-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate server-side exceptions as classes #502
generate server-side exceptions as classes #502
Conversation
The commit for the generated code linked in the PR description says |
@gosar Yes, they will be renamed to ServiceExceptions. Updated the description. |
...ript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/StructureGenerator.java
Outdated
Show resolved
Hide resolved
.../java/software/amazon/smithy/typescript/codegen/integration/AddBaseExceptionClassExport.java
Outdated
Show resolved
Hide resolved
...ript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/StructureGenerator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the link in the description of the PR with the latest generated code
...-codegen/src/main/java/software/amazon/smithy/typescript/codegen/StructuredMemberWriter.java
Outdated
Show resolved
Hide resolved
.../java/software/amazon/smithy/typescript/codegen/integration/AddBaseExceptionClassExport.java
Outdated
Show resolved
Hide resolved
a0a7568
to
5586a0f
Compare
3495b3c
to
730fb37
Compare
...pescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/IndexGenerator.java
Outdated
Show resolved
Hide resolved
...ript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/StructureGenerator.java
Outdated
Show resolved
Hide resolved
...ript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/StructureGenerator.java
Show resolved
Hide resolved
This reverts commit 34e1a3a.
…the ssdk generation
9224cf3
to
c653965
Compare
98ceb16
to
b72fac7
Compare
b72fac7
to
2d6daea
Compare
This change generates server-side exceptions as individual classes. So customers can handle exceptions with ease.
Issue #, if available:
Related to aws/aws-sdk-js-v3#3261
SSDK generated example: aws/aws-sdk-js-v3#3310
Description of changes:
This change generates server-side exceptions as individual classes. So customers can handle exceptions with ease.
You can view generated code diff at aws/aws-sdk-js-v3#3267
Now the customer can handle the errors without hardcoding the error code:
For SSDK, customer can do the similar:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.