chore: Introduce Option to specify repository URL #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make repository URL configurable
PeterSchafer
changed the title
PeterSchafer
changed the title
| @@ -76,7 +76,7 @@ | |||
| "providerState": "Scan ID", | |||
| "request": { | |||
| "method": "GET", | |||
| "path": "/orgs/e7ea34c9-de0f-422c-bf2c-4654c2e2da90/scans/d164a5fa-444e-4ed6-a08f-c4e08a9f20a2", | |||
| "path": "/orgs/e7ea34c9-de0f-422c-bf2c-4654c2e2da90/scans/748d5bd0-9ce5-4cb9-876a-24c5601036ea", | |||
There was a problem hiding this comment.
Do you have any idea why this changed?
There was a problem hiding this comment.
Nevermind, I know. I'll fix it, I implemented these tests in a non-determinstic way 🙊
teodora-sandu
approved these changes
May 10, 2024
Merged
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to specify the repository associated with a given path. This can be used if the automatic detection of a repository URL doesn't work.
Therefore it introduces a data structure (scan.Target) to specify what is being scanned, which can in addition to the path hold a repository URL. The automatic URL determination is moved from the analysis logic to the new data structure.