feat: Enabling SCLE [NEBULA-1371] #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
metju90
force-pushed
the
feat/enable-scle
branch
from
e9b5337 to
4558d57
Compare
metju90
commented
Aug 28, 2023
metju90
commented
Aug 29, 2023
There was a problem hiding this comment.
detekt found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
metju90
force-pushed
the
feat/enable-scle
branch
from
7c17b25 to
ff0bba8
Compare
metju90
force-pushed
the
feat/enable-scle
branch
from
0b728e2 to
ad0a05e
Compare
src/main/kotlin/io/snyk/plugin/ui/toolwindow/SnykToolWindowPanel.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Matthew Barbara <[email protected]>
| @@ -29,11 +31,22 @@ class SnykApiClient( | |||
| log.debug("Executing request to $apiName") | |||
| val response = retrofitCall.execute() | |||
| if (!response.isSuccessful) { | |||
| if (response.code() == HttpStatusCode.UnprocessableEntity.value) { | |||
| val responseBodyString = response.errorBody()?.string() | |||
| val errorBody= Gson().fromJson<CliConfigSettingsError?>(responseBodyString, CliConfigSettingsError::class.java) | |||
There was a problem hiding this comment.
Please fix the linter stuff :)
| @@ -48,7 +48,9 @@ class SnykApplicationSettingsStateService : PersistentStateComponent<SnykApplica | |||
| var containerScanEnabled: Boolean = true | |||
|
|
|||
| var sastOnServerEnabled: Boolean? = null | |||
| var sastSettingsError: Boolean? = null; | |||
| @@ -219,25 +221,34 @@ class ScanTypesPanel( | |||
| return | |||
| } | |||
|
|
|||
| var sastSettingsError: String = "" | |||
| val sastCliConfigSettings: CliConfigSettings? = | |||
| try { | |||
Signed-off-by: Matthew Barbara <[email protected]>
Comment on lines
3
to
17
| import io.mockk.mockk | ||
| import io.mockk.every | ||
| import io.mockk.mockkStatic | ||
| import io.mockk.unmockkAll | ||
| import junit.framework.TestCase.assertFalse | ||
| import junit.framework.TestCase.assertTrue | ||
| import org.hamcrest.core.IsEqual.equalTo | ||
| import org.junit.Assert.assertThat | ||
| import org.junit.Test | ||
| import org.junit.Before | ||
| import java.net.URI | ||
| import io.snyk.plugin.pluginSettings | ||
| import io.snyk.plugin.services.SnykApplicationSettingsStateService | ||
| import junit.framework.TestCase.assertEquals | ||
| import org.junit.After |
Check warning
Code scanning / detekt
Detects imports in non default order
Signed-off-by: Matthew Barbara <[email protected]>
Signed-off-by: Matthew Barbara <[email protected]>
metju90
force-pushed
the
feat/enable-scle
branch
from
d2c8e55 to
2db4deb
Compare
bastiandoetsch
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables SCLE