Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont use kotlin specific convenience function #544

Merged
merged 2 commits into from
Jun 11, 2024
Merged

fix: dont use kotlin specific convenience function #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24bc8bd
fix: dont use kotlin specific convenience function
bastiandoetsch Jun 11, 2024
aa53263
docs: update CHANGELOG.md
bastiandoetsch Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Snyk Security Changelog

## [2.8.4]
### Fixed
- dont use kotlin specific convenience function that may cause errors on non kotlin IDEs

## [2.8.3]

### Added
Expand Down
4 changes: 2 additions & 2 deletions src/main/kotlin/snyk/common/lsp/SnykLanguageClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import com.github.benmanes.caffeine.cache.RemovalListener
import com.intellij.ide.impl.ProjectUtil
import com.intellij.openapi.actionSystem.AnAction
import com.intellij.openapi.actionSystem.AnActionEvent
import com.intellij.openapi.application.ApplicationManager
import com.intellij.openapi.application.ReadAction
import com.intellij.openapi.command.WriteCommandAction
import com.intellij.openapi.components.service
Expand Down Expand Up @@ -47,7 +48,6 @@ import org.eclipse.lsp4j.WorkDoneProgressReport
import org.eclipse.lsp4j.jsonrpc.services.JsonNotification
import org.eclipse.lsp4j.services.LanguageClient
import org.jetbrains.concurrency.runAsync
import org.jetbrains.kotlin.idea.util.application.executeOnPooledThread
import snyk.common.ProductType
import snyk.common.SnykFileIssueComparator
import snyk.trust.WorkspaceTrustService
Expand Down Expand Up @@ -374,7 +374,7 @@ class SnykLanguageClient() : LanguageClient {
MessageType.Warning -> SnykBalloonNotificationHelper.showWarn(messageParams.message, project)
MessageType.Info -> {
val notification = SnykBalloonNotificationHelper.showInfo(messageParams.message, project)
executeOnPooledThread {
ApplicationManager.getApplication().executeOnPooledThread {
Thread.sleep(5000)
notification.expire()
}
Expand Down
Loading