fix: dataflow links work across files [IDE-391] #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
29
to
32
| val virtualFile = | ||
| VirtualFileManager.getInstance().findFileByNioPath(Paths.get(filePath)) | ||
| ?: return JBCefJSQuery.Response("error") | ||
|
|
There was a problem hiding this comment.
Is there a chance to pre-calculate the VirtualFile? IntelliJ doesn't like to do this kind of thing in the UI thread and will log a warning/error if it takes too long.
There was a problem hiding this comment.
Good suggestion, I think I did that in cbe9859. Basically just pre-computing the virtual files before building the query used by the UI
bastiandoetsch
approved these changes
Jun 17, 2024
teodora-sandu
force-pushed
the
fix/dataflow-links-files
branch
from
90912c2 to
b5fa11d
Compare
teodora-sandu
force-pushed
the
fix/dataflow-links-files
branch
from
b5fa11d to
cbe9859
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change in this PR is to load the virtual file from the
filePathin the component instead of using the provided virtual file. This way we can navigate to lines in other files that are not the originating file of the issue.There are some linting changes too, after configuring the default linter in IntelliJ to format on save.
Checklist
Screenshots / GIFs
Screen.Recording.2024-06-14.at.16.41.58.mov