Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: root.unwrap for samplers #872

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: root.unwrap for samplers #872

wants to merge 15 commits into from

Conversation

mhawryluk
Copy link
Collaborator

closes #772

Copy link

codesandbox-ci bot commented Feb 14, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented Feb 16, 2025

pkg.pr.new

packages

pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@872
pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@36505ce56201598174ae518ea3ef95701df5e015

benchmark
view benchmark

commit
view commit

Copy link
Collaborator

@reczkok reczkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good👍

Copy link
Collaborator

@iwoplaza iwoplaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INTERNAL_ types please 🙏

/**
* NOTE: Internal use only
*/
unwrap(branch: ExperimentalTgpuRoot): GPUSampler {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Unwrapper type instead of ExperimentalTgpuRoot

Suggested change
unwrap(branch: ExperimentalTgpuRoot): GPUSampler {
unwrap(branch: ExperimentalTgpuRoot): GPUSampler {

@mhawryluk mhawryluk requested a review from iwoplaza February 24, 2025 17:46
Copy link
Collaborator

@iwoplaza iwoplaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOHOO 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement root.unwrap for samplers
4 participants