dx: Fetch dependency versions automatically from codebase in openInStackBlitz function #939
Conversation
…ackBlitz function
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
pkg.pr.new packages benchmark commit |
There was a problem hiding this comment.
Awesome, this reduces a lot of the friction we encounter while deploying 🙌 🚀
I have one request, could we try out @std/yaml from the JSR & Deno folk instead of js-yaml? It seems to have type definitions out of the box, and it's more likely to get patch updates down the line.
As for the "as { ... }" after loading the Yaml, could we use arktype for validating whether or not the config file matches what we expect? This way, if we ever change the workspace config file in an unexpected way, we'll be notified properly.
| if (pnpmWorkspaceYaml instanceof type.errors) { | ||
| throw new Error(pnpmWorkspaceYaml.message); | ||
| } | ||
|
|
There was a problem hiding this comment.
Imo, we could move this error check outside of the function to be aware of failure earlier, not requiring the button click.
closes #937