Start app as application #59
Conversation
| @@ -0,0 +1,75 @@ | |||
| defmodule LiveDebugger.Helpers do | |||
There was a problem hiding this comment.
I don't know if this is a correct name for this module but the LiveDebugger will have application setup so button needs to me moved elsewhere.
There was a problem hiding this comment.
Regarding our IRL conversation using static assets works fine. These were the LiveBook errors which I've seen
README.md
Outdated
| config :live_debugger, LiveDebugger.Endpoint, | ||
| http: [port: 4007], # Add port on which you want debugger to run | ||
| secret_key_base: <SECRET_KEY_BASE>, # Generate secret using `mix phx.gen.secret` | ||
| live_view: [signing_salt: <SIGNING_SALT>], # Random 12 letter salt | ||
| adapter: Bandit.PhoenixAdapter # Change to your adapter if other is used (see your Endpoint config) |
There was a problem hiding this comment.
I feel like we should've add some default values and allow user to modify them but adding some default secrets seems a little bit weird.
README.md
Outdated
| And add the debug button to your live layout: | ||
| For easy navigation add the debug button to your live layout | ||
|
|
||
| ```Elixir | ||
| # lib/my_app_web/components/app.html.heex | ||
|
|
There was a problem hiding this comment.
I won't find solution to the waring in prod in this task so I've left this comment (not everyone needs to use button)
GuzekAlan
force-pushed
the
start-app-as-application
branch
from
0ec4be2 to
3486226
Compare
|
I've checked it with LiveBook and newly created LiveView app on prod and dev env and it works fine. |
| @@ -36,6 +36,11 @@ defmodule LiveDebuggerDev.Runner do | |||
| ] | |||
|
|
|||
| {:ok, _} = Supervisor.start_link(children, strategy: :one_for_one) | |||
|
|
|||
| # For some reason `Application.put_env` doesn't work and LiveDebugger starts without config | |||
| Application.stop(:live_debugger) | |||
There was a problem hiding this comment.
You've already started LiveDebugger via supervisor
There was a problem hiding this comment.
I've struggled a lot with it and for some reason LiveDebugger.Endpoint has proper configuration but the application doesn't start. I assume that the code of our application might be run before this line but I am not 100% sure
| @@ -36,6 +36,11 @@ defmodule LiveDebuggerDev.Runner do | |||
| ] | |||
|
|
|||
| {:ok, _} = Supervisor.start_link(children, strategy: :one_for_one) | |||
|
|
|||
| # For some reason `Application.put_env` doesn't work and LiveDebugger starts without config | |||
There was a problem hiding this comment.
We'll have to discuss it on Monday
| @@ -0,0 +1,75 @@ | |||
| defmodule LiveDebugger.Helpers do | |||
No description provided.