This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
getConfirmedBlocks now has an upper limit on slot range #10927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10927 +/- ##
=========================================
- Coverage 82.1% 82.0% -0.1%
=========================================
Files 316 316
Lines 72000 72020 +20
=========================================
- Hits 59130 59128 -2
- Misses 12870 12892 +22 |
CriesofCarrots
approved these changes
Jul 6, 2020
This was referenced Jul 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getConfirmedBlockspotentially allows the user to request the full confirmed slot range from genesis up to the latest. We don't want to bind up an RPC server thread for that long, especially once we support a longer transaction history. Impose a very generous limit of 500,000 slots, which is larger than the number of slots per epoch on on mainnet-beta.