This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
adds an optional encoding for serializing duplicate shreds #14362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14362 +/- ##
=========================================
- Coverage 80.3% 80.3% -0.1%
=========================================
Files 403 404 +1
Lines 101131 101219 +88
=========================================
+ Hits 81283 81346 +63
- Misses 19848 19873 +25 |
behzadnouri
force-pushed
the
encode
branch
2 times, most recently
from
09be5db to
3952f32
Compare
sakridge
reviewed
Jan 1, 2021
| Encoded::Deflate(bytes) => Box::new(DeflateDecoder::new(&bytes[..])), | ||
| Encoded::Gzip(bytes) => Box::new(GzDecoder::new(&bytes[..])), | ||
| Encoded::Zlib(bytes) => Box::new(ZlibDecoder::new(&bytes[..])), | ||
| Encoded::Zstd(bytes) => Box::new(zstd::stream::read::Decoder::new(&bytes[..])?), |
There was a problem hiding this comment.
Are these decoders hardened against zip-bomb-like behavior?
There was a problem hiding this comment.
I raised that question to the upstream package; and meanwhile, added a limit here for number of bytes decoded.
behzadnouri
force-pushed
the
encode
branch
2 times, most recently
from
a39eb29 to
9c4acc2
Compare
behzadnouri
force-pushed
the
encode
branch
2 times, most recently
from
fd1c189 to
1d1b6f5
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
|
This stale pull request has been automatically closed. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The payload for
DuplicateShredis larger than what can fit in one packet.Currently this is split up into multiple chunks, each with its own added
overhead, Plus the overhead when these are wrapped in gossip messages:
https://github.com/solana-labs/solana/blob/cb8ba739a/core/src/duplicate_shred.rs#L32-L36
Compressing the payload may reduce the number of chunks needed to send one
complete duplicate slot proof over gossip.
Summary of Changes
down gossip.