This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
implement ancestors as rolling bit field #17482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
ancestors
branch
6 times, most recently
from
cb1b479 to
63e23e1
Compare
Codecov Report
@@ Coverage Diff @@
## master #17482 +/- ##
=======================================
Coverage 82.6% 82.7%
=======================================
Files 427 427
Lines 119537 119462 -75
=======================================
- Hits 98851 98798 -53
+ Misses 20686 20664 -22 |
jeffwashington
force-pushed
the
ancestors
branch
3 times, most recently
from
bb73c44 to
a662584
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jun 2, 2021
(cherry picked from commit eec996b)
jeffwashington
added a commit
that referenced
this pull request
Jun 3, 2021
(cherry picked from commit eec996b)
mergify bot
added a commit
that referenced
this pull request
Jun 3, 2021
(cherry picked from commit eec996b) Co-authored-by: Jeff Washington (jwash) <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ancestors has gone from HashMap<Slot, usize> to HashSet
Summary of Changes
implement Ancestors in a more performant and straightforward manner using the RollingBitField we use for roots.
Fixes #