This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Add block height to ConfirmedBlock structs #17523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
force-pushed
the
block-height
branch
from
4bcc388 to
8e24c3b
Compare
CriesofCarrots
commented
May 26, 2021
mvines
previously approved these changes
May 26, 2021
| @@ -2126,6 +2126,9 @@ impl fmt::Display for CliBlock { | |||
| if let Some(block_time) = self.encoded_confirmed_block.block_time { | |||
| writeln!(f, "Block Time: {:?}", Local.timestamp(block_time, 0))?; | |||
| } | |||
| if let Some(block_height) = self.encoded_confirmed_block.block_height { | |||
There was a problem hiding this comment.
heh, I foresee support issues when people now start running solana block <BLOCK> instead of solana block <SLOT>
There was a problem hiding this comment.
Totally. solana block-by-height in our future?
There was a problem hiding this comment.
solana-ledger-tool slot ... got it right though! oh well :)
mvines
reviewed
May 26, 2021
carllin
reviewed
May 26, 2021
carllin
reviewed
May 26, 2021
carllin
reviewed
May 26, 2021
carllin
reviewed
May 26, 2021
added 8 commits
May 26, 2021 17:52
CriesofCarrots
force-pushed
the
block-height
branch
from
8e24c3b to
04af03d
Compare
CriesofCarrots
force-pushed
the
block-height
branch
from
04af03d to
060b995
Compare
Codecov Report
@@ Coverage Diff @@
## master #17523 +/- ##
=========================================
- Coverage 82.6% 82.6% -0.1%
=========================================
Files 427 427
Lines 119005 119057 +52
=========================================
+ Hits 98409 98421 +12
- Misses 20596 20636 +40 |
mvines
approved these changes
May 27, 2021
mergify bot
pushed a commit
that referenced
this pull request
May 27, 2021
* Add BlockHeight CF to blockstore * Rename CacheBlockTimeService to be more general * Cache block-height using service * Fixup previous proto mishandling * Add block_height to block structs * Add block-height to solana block * Fallback to BankForks if block time or block height are not yet written to Blockstore * Add docs * Review comments (cherry picked from commit ab581da) # Conflicts: # core/src/replay_stage.rs # core/src/tvu.rs # core/src/validator.rs
mvines
pushed a commit
that referenced
this pull request
May 27, 2021
* Add block height to ConfirmedBlock structs (#17523) * Add BlockHeight CF to blockstore * Rename CacheBlockTimeService to be more general * Cache block-height using service * Fixup previous proto mishandling * Add block_height to block structs * Add block-height to solana block * Fallback to BankForks if block time or block height are not yet written to Blockstore * Add docs * Review comments (cherry picked from commit ab581da) # Conflicts: # core/src/replay_stage.rs # core/src/tvu.rs # core/src/validator.rs * Fix conflicts Co-authored-by: Tyera Eulberg <[email protected]> Co-authored-by: Tyera Eulberg <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As of #17506,
last_valid_block_heightis available to assess recent-blockhash expiration. But it is only possible to get the block height of the current Bank (viagetBlockHeightorgetEpochInforpcs).Summary of Changes