Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

add metric for collecting storages #17527

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

jeffwashington
Copy link
Contributor

@jeffwashington jeffwashington commented May 26, 2021

Problem

we don't know how long it takes to collect storages for hash calculation.

Summary of Changes

add a metric.
Fixes #

@jeffwashington jeffwashington force-pushed the hash42 branch 3 times, most recently from f1e94a7 to 7e78d5c Compare May 26, 2021 22:52
@jeffwashington
Copy link
Contributor Author

datapoint: calculate_accounts_hash_without_index accounts_scan=2308835i eliminate_zeros=404897i hash=250392i sort=1838954i hash_total=61837974i flatten=1571118i unreduced_entries=62270664i collect_snapshots_us=231946i num_snapshot_storage=372887i total=6606142i

@jeffwashington jeffwashington marked this pull request as ready for review May 27, 2021 04:03
@lijunwangs lijunwangs self-requested a review May 27, 2021 17:12
lijunwangs
lijunwangs previously approved these changes May 27, 2021
Copy link
Contributor

@lijunwangs lijunwangs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot dismissed lijunwangs’s stale review May 28, 2021 18:13

Pull request has been modified.

@jeffwashington jeffwashington merged commit 72bb271 into solana-labs:master Jun 1, 2021
jeffwashington added a commit to jeffwashington/solana that referenced this pull request Jun 1, 2021
jeffwashington added a commit to jeffwashington/solana that referenced this pull request Jun 1, 2021
jeffwashington added a commit to jeffwashington/solana that referenced this pull request Jun 1, 2021
mergify bot pushed a commit that referenced this pull request Jun 2, 2021
(cherry picked from commit 72bb271)

# Conflicts:
#	runtime/src/accounts_db.rs
#	runtime/src/snapshot_utils.rs
jeffwashington added a commit that referenced this pull request Jun 3, 2021
(cherry picked from commit 72bb271)

# Conflicts:
#	runtime/src/accounts_db.rs
#	runtime/src/snapshot_utils.rs
mergify bot added a commit that referenced this pull request Jun 3, 2021
(cherry picked from commit 72bb271)

# Conflicts:
#	runtime/src/accounts_db.rs
#	runtime/src/snapshot_utils.rs

Co-authored-by: Jeff Washington (jwash) <[email protected]>
@brooksprumo brooksprumo mentioned this pull request Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants