This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
refactor SnapshotStorage helpers to prepare for later changes #17560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
reviewed
May 27, 2021
brooksprumo
previously approved these changes
May 27, 2021
Codecov Report
@@ Coverage Diff @@
## master #17560 +/- ##
=========================================
- Coverage 82.6% 82.6% -0.1%
=========================================
Files 427 427
Lines 119486 119496 +10
=========================================
- Hits 98813 98761 -52
- Misses 20673 20735 +62 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 2, 2021
(cherry picked from commit 654918a) # Conflicts: # runtime/src/accounts_db.rs
jeffwashington
added a commit
that referenced
this pull request
Jun 3, 2021
(cherry picked from commit 654918a) # Conflicts: # runtime/src/accounts_db.rs
mergify bot
added a commit
that referenced
this pull request
Jun 3, 2021
#17678) (cherry picked from commit 654918a) # Conflicts: # runtime/src/accounts_db.rs Co-authored-by: Jeff Washington (jwash) <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Storages are likely to be changed soon.
Summary of Changes
Make some helper test methods for common test values to remove noise from more interesting PRs.
Fixes #