Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

rework test for flexibility #17592

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

jeffwashington
Copy link
Contributor

@jeffwashington jeffwashington commented May 28, 2021

Problem

These tests are about to be hit by changes to storages, such as sorting and moving slot numbers. The changes are noisy.

Summary of Changes

Make the noisy test change separately.
Fixes #

@jeffwashington jeffwashington marked this pull request as ready for review May 28, 2021 21:33
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some simple questions I wanted to double check.

@codecov
Copy link

codecov bot commented May 29, 2021

Codecov Report

Merging #17592 (0d028c0) into master (cf5ad7c) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #17592   +/-   ##
=======================================
  Coverage    82.6%    82.6%           
=======================================
  Files         427      427           
  Lines      119542   119551    +9     
=======================================
+ Hits        98831    98848   +17     
+ Misses      20711    20703    -8     

@jeffwashington jeffwashington merged commit 886898e into solana-labs:master Jun 1, 2021
lieuzhenghong pushed a commit to lieuzhenghong/solana that referenced this pull request Jun 2, 2021
* rework test for flexibility

* respond to pr feedback
mergify bot pushed a commit that referenced this pull request Jun 2, 2021
* rework test for flexibility

* respond to pr feedback

(cherry picked from commit 886898e)

# Conflicts:
#	runtime/src/accounts_db.rs
jeffwashington added a commit that referenced this pull request Jun 3, 2021
* rework test for flexibility

* respond to pr feedback

(cherry picked from commit 886898e)

# Conflicts:
#	runtime/src/accounts_db.rs
jeffwashington added a commit that referenced this pull request Jun 3, 2021
* rework test for flexibility

* respond to pr feedback

(cherry picked from commit 886898e)

# Conflicts:
#	runtime/src/accounts_db.rs
jeffwashington added a commit that referenced this pull request Jun 3, 2021
* rework test for flexibility

* respond to pr feedback

(cherry picked from commit 886898e)

# Conflicts:
#	runtime/src/accounts_db.rs
jeffwashington added a commit that referenced this pull request Jun 3, 2021
* rework test for flexibility

* respond to pr feedback

(cherry picked from commit 886898e)

# Conflicts:
#	runtime/src/accounts_db.rs
jeffwashington added a commit that referenced this pull request Jun 3, 2021
* rework test for flexibility

* respond to pr feedback

(cherry picked from commit 886898e)

# Conflicts:
#	runtime/src/accounts_db.rs
mergify bot added a commit that referenced this pull request Jun 3, 2021
* rework test for flexibility

* respond to pr feedback

(cherry picked from commit 886898e)

# Conflicts:
#	runtime/src/accounts_db.rs

Co-authored-by: Jeff Washington (jwash) <[email protected]>
@brooksprumo brooksprumo mentioned this pull request Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants