This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
reviewed
May 28, 2021
brooksprumo
reviewed
May 28, 2021
brooksprumo
reviewed
May 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some simple questions I wanted to double check.
brooksprumo
approved these changes
May 28, 2021
Codecov Report
@@ Coverage Diff @@
## master #17592 +/- ##
=======================================
Coverage 82.6% 82.6%
=======================================
Files 427 427
Lines 119542 119551 +9
=======================================
+ Hits 98831 98848 +17
+ Misses 20711 20703 -8 |
lieuzhenghong
pushed a commit
to lieuzhenghong/solana
that referenced
this pull request
Jun 2, 2021
* rework test for flexibility * respond to pr feedback
mergify bot
pushed a commit
that referenced
this pull request
Jun 2, 2021
* rework test for flexibility * respond to pr feedback (cherry picked from commit 886898e) # Conflicts: # runtime/src/accounts_db.rs
jeffwashington
added a commit
that referenced
this pull request
Jun 3, 2021
* rework test for flexibility * respond to pr feedback (cherry picked from commit 886898e) # Conflicts: # runtime/src/accounts_db.rs
jeffwashington
added a commit
that referenced
this pull request
Jun 3, 2021
* rework test for flexibility * respond to pr feedback (cherry picked from commit 886898e) # Conflicts: # runtime/src/accounts_db.rs
jeffwashington
added a commit
that referenced
this pull request
Jun 3, 2021
* rework test for flexibility * respond to pr feedback (cherry picked from commit 886898e) # Conflicts: # runtime/src/accounts_db.rs
jeffwashington
added a commit
that referenced
this pull request
Jun 3, 2021
* rework test for flexibility * respond to pr feedback (cherry picked from commit 886898e) # Conflicts: # runtime/src/accounts_db.rs
jeffwashington
added a commit
that referenced
this pull request
Jun 3, 2021
* rework test for flexibility * respond to pr feedback (cherry picked from commit 886898e) # Conflicts: # runtime/src/accounts_db.rs
mergify bot
added a commit
that referenced
this pull request
Jun 3, 2021
* rework test for flexibility * respond to pr feedback (cherry picked from commit 886898e) # Conflicts: # runtime/src/accounts_db.rs Co-authored-by: Jeff Washington (jwash) <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
These tests are about to be hit by changes to storages, such as sorting and moving slot numbers. The changes are noisy.
Summary of Changes
Make the noisy test change separately.
Fixes #