This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Bump compute budget for neon evm #17700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17700 +/- ##
=========================================
- Coverage 82.8% 82.7% -0.1%
=========================================
Files 431 432 +1
Lines 120590 120601 +11
=========================================
- Hits 99853 99839 -14
- Misses 20737 20762 +25 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
|
This stale pull request has been automatically closed. Thank you for your contributions. |
stale
bot
removed
the
stale
|
@s-medvedev do you still need the heap bumped? |
jackcmay
force-pushed
the
neom-evm-compute-budget
branch
from
b71e0c1 to
421a19b
Compare
Yes, we need to increase the heap size for the contract to work. Uniswap tests show that 256 KB will be sufficient. |
jackcmay
force-pushed
the
neom-evm-compute-budget
branch
4 times, most recently
from
ad76d1b to
78708ce
Compare
jackcmay
force-pushed
the
neom-evm-compute-budget
branch
from
78708ce to
546eb12
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jul 8, 2021
(cherry picked from commit 2867584) # Conflicts: # sdk/src/process_instruction.rs
jackcmay
added a commit
that referenced
this pull request
Jul 8, 2021
(cherry picked from commit 2867584) # Conflicts: # sdk/src/process_instruction.rs
jackcmay
added a commit
that referenced
this pull request
Jul 8, 2021
(cherry picked from commit 2867584)
jackcmay
added a commit
that referenced
this pull request
Jul 9, 2021
(cherry picked from commit 2867584) Co-authored-by: Jack May <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Neon EVM requires a larger compute budget than the default
Summary of Changes
Bump the max compute units and the heap size for the Neon EVM program. These are stop-gap changes that eventually will tie into tx-wide compute caps and optional fee-based compute budget bumps.
Fixes #