This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Remove budget program #17816
Merged
Remove budget program #17816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
commented
Jun 7, 2021
jeffwashington
approved these changes
Jun 7, 2021
garious
approved these changes
Jun 7, 2021
CriesofCarrots
added
v1.7
automerge
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
CriesofCarrots
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #17816 +/- ##
=========================================
- Coverage 82.7% 82.7% -0.1%
=========================================
Files 433 428 -5
Lines 120681 120150 -531
=========================================
- Hits 99901 99411 -490
+ Misses 20780 20739 -41 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 8, 2021
(cherry picked from commit a66566e) # Conflicts: # Cargo.lock # genesis/Cargo.toml # ledger/Cargo.toml # perf/Cargo.toml # programs/budget/Cargo.toml
mergify bot
added a commit
that referenced
this pull request
Jun 8, 2021
* Remove budget program (#17816) (cherry picked from commit a66566e) # Conflicts: # Cargo.lock # genesis/Cargo.toml # ledger/Cargo.toml # perf/Cargo.toml # programs/budget/Cargo.toml * Fix conflicts Co-authored-by: Tyera Eulberg <[email protected]> Co-authored-by: Tyera Eulberg <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Tidying up. While no longer blocking Account data changes, the budget program is still unnecessary as per #16960. We know how to get it back if we need it.
Summary of Changes
Remove budget program and use other programs/instructions in tests
Closes #16960