Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

minor fixes to punctuation and typos #17881

Merged
merged 6 commits into from
Jun 14, 2021
Merged

Conversation

JohnDoe389
Copy link
Contributor

Problem

some typos and confusing punctuation

Summary of Changes

if there isn't someone already heavily editing the documentation, i will continue providing these minor corrections...please let me know

Fixes #

@mergify mergify bot added the community Community contribution label Jun 10, 2021
@jstarry
Copy link
Contributor

jstarry commented Jun 11, 2021

Doc fixes are very welcome but please ensure that lines are wrapped and the format sanity checks pass, thanks!

@JohnDoe389
Copy link
Contributor Author

will do! wow Justin...super impressed with your speed on getting to this...tx

@jstarry
Copy link
Contributor

jstarry commented Jun 11, 2021

will do! wow Justin...super impressed with your speed on getting to this...tx

heh, I'm impressed too. CI is still failing btw

@JohnDoe389 JohnDoe389 marked this pull request as draft June 11, 2021 09:51
@JohnDoe389
Copy link
Contributor Author

tx...converted the pr to a draft for now

using the `SystemProgram::CreateAccount` instruction with preallocated a fixed
storage size in bytes. The current maximum size of an account's data is 10
megabytes.
To create an account, a client generates a _keypair_ and registers its public key
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just change "a" to "and" in "preallocated and fixed"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi Jack...missed seeing your comment "How about just change "a" to "and" in "preallocated and fixed"...let me go back and look at that again

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it is relevant after the latest round of changes :-)

@jackcmay
Copy link
Contributor

@JohnDoe389 You can move it out of draft and besides one nit it looked great. When it passes CI we'll merge it.

Our CI prevents extra whitespace, looks like that is what is holding up CI currently: https://buildkite.com/solana-labs/solana/builds/48527#96f2c563-99c6-4bc0-98f9-95e35496a772

@JohnDoe389
Copy link
Contributor Author

thank you Jack!...if u can give me an hour i have another commit with that fixed and with improvements to the staking page as well.

@JohnDoe389 JohnDoe389 marked this pull request as ready for review June 11, 2021 20:50
@JohnDoe389
Copy link
Contributor Author

looks like i need to check for trailing white space...brb

@jackcmay
Copy link
Contributor

@JohnDoe389 Looking good so far, looks like there are still trailing whitspaces

@jackcmay jackcmay added the v1.7 label Jun 14, 2021
@jackcmay jackcmay merged commit 54155f8 into solana-labs:master Jun 14, 2021
mergify bot pushed a commit that referenced this pull request Jun 14, 2021
* fix minor typos and punctuation

* fix minor typos and punctuation

* rewording for clarity and typo corrections

* rewording for clarity and typo corrections

* rewording for clarity and typo corrections

Co-authored-by: Gregg Dourgarian <[email protected]>
(cherry picked from commit 54155f8)
@jackcmay
Copy link
Contributor

Thanks @JohnDoe389 for the contribution!

mergify bot added a commit that referenced this pull request Jun 14, 2021
* fix minor typos and punctuation

* fix minor typos and punctuation

* rewording for clarity and typo corrections

* rewording for clarity and typo corrections

* rewording for clarity and typo corrections

Co-authored-by: Gregg Dourgarian <[email protected]>
(cherry picked from commit 54155f8)

Co-authored-by: Haik Dulgarian <[email protected]>
@brooksprumo brooksprumo mentioned this pull request Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants