-
Notifications
You must be signed in to change notification settings - Fork 4.7k
minor fixes to punctuation and typos #17881
Conversation
Doc fixes are very welcome but please ensure that lines are wrapped and the format sanity checks pass, thanks! |
will do! wow Justin...super impressed with your speed on getting to this...tx |
heh, I'm impressed too. CI is still failing btw |
tx...converted the pr to a draft for now |
using the `SystemProgram::CreateAccount` instruction with preallocated a fixed | ||
storage size in bytes. The current maximum size of an account's data is 10 | ||
megabytes. | ||
To create an account, a client generates a _keypair_ and registers its public key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about just change "a" to "and" in "preallocated and fixed"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi Jack...missed seeing your comment "How about just change "a" to "and" in "preallocated and fixed"...let me go back and look at that again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it is relevant after the latest round of changes :-)
@JohnDoe389 You can move it out of draft and besides one nit it looked great. When it passes CI we'll merge it. Our CI prevents extra whitespace, looks like that is what is holding up CI currently: https://buildkite.com/solana-labs/solana/builds/48527#96f2c563-99c6-4bc0-98f9-95e35496a772 |
thank you Jack!...if u can give me an hour i have another commit with that fixed and with improvements to the staking page as well. |
looks like i need to check for trailing white space...brb |
@JohnDoe389 Looking good so far, looks like there are still trailing whitspaces |
* fix minor typos and punctuation * fix minor typos and punctuation * rewording for clarity and typo corrections * rewording for clarity and typo corrections * rewording for clarity and typo corrections Co-authored-by: Gregg Dourgarian <[email protected]> (cherry picked from commit 54155f8)
Thanks @JohnDoe389 for the contribution! |
* fix minor typos and punctuation * fix minor typos and punctuation * rewording for clarity and typo corrections * rewording for clarity and typo corrections * rewording for clarity and typo corrections Co-authored-by: Gregg Dourgarian <[email protected]> (cherry picked from commit 54155f8) Co-authored-by: Haik Dulgarian <[email protected]>
Problem
some typos and confusing punctuation
Summary of Changes
if there isn't someone already heavily editing the documentation, i will continue providing these minor corrections...please let me know
Fixes #