Refactor stake program into solana_program

[joncinque]

Problem

The solana_stake_program crate is not available on-chain, causing programs to copy all of its code where needed. This was flagged by the stake pool audit at solana-labs/solana-program-library#1865

Summary of Changes

Move the essential instruction and state types into solana_program. In order to move as little as possible, new types were introduced (renamed from the stake program core types) in solana_stake_program which require sdk-level types. There's a few little goofy parts, mainly having the StakeConfig struct implement ConfigState in the config program directly, and a few functions in the StakeConverter type which should really belong directly on the Stake type in solana_program, but that will require the vote program to be moved over as well.

Note that no logic was changed, this is entirely a refactor. CI will probably catch any lingering issues, so I'll fix them all as they're flagged up.

Fixes #

[codecov]

Codecov Report

Merging #17906 (a55ae3a) into master (1f38bf2) will increase coverage by 0.0%.
The diff coverage is 90.5%.

@@           Coverage Diff           @@
##           master   #17906   +/-   ##
=======================================
  Coverage    82.6%    82.6%           
=======================================
  Files         431      435    +4     
  Lines      121614   121584   -30     
=======================================
+ Hits       100460   100497   +37     
+ Misses      21154    21087   -67     

[CriesofCarrots]

Wdyt about calling the new module sdk/program/src/stake_program/..? I know that's a change from how we're handling things in the programs directory, but I find all the stake::id() declarations pretty terse, esp in contrast with system_program::id()

[t-nelson]

Wdyt about calling the new module sdk/program/src/stake_program/..?

An alternative could be to wrap the declare_id!() in pub mod program { }

[CriesofCarrots]

An alternative could be to wrap the declare_id!() in pub mod program { }

Oh totally, something like this could be better than renaming the directory.

[t-nelson]

I'm wondering if we should maintain pub use of the public API features from the solana-stake-program crate to avoid breaking any external consumers? stake-o-matic comes to mind. They can probably be marked with the deprecated attribute.

[joncinque]

Wdyt about calling the new module sdk/program/src/stake_program/..?

I hesitated a lot with the name of stake over stake_program -- either works for me! Calling it stake_program when the actual processor code is elsewhere seemed weird to me, but the system_program example seems to set the standard for keeping the _program suffix. On the other hand, I do like the stake::program::id(). If I get both of your 👍 on that, I'll do it!

[joncinque]

I'm wondering if we should maintain pub use of the public API features from the solana-stake-program crate to avoid breaking any external consumers? stake-o-matic comes to mind. They can probably be marked with the deprecated attribute.

Good idea, I'll do that

[joncinque]

maintain pub use of the public API features from the solana-stake-program crate to avoid breaking any external consumers

@t-nelson done in 4631664

[joncinque]

This is ready for another review on my side

[CriesofCarrots]

lgtm! Couple nits

Pull request has been modified.