This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
add metrics for startup #17913
Merged
add metrics for startup #17913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17913 +/- ##
=========================================
- Coverage 82.6% 82.6% -0.1%
=========================================
Files 431 431
Lines 121295 121321 +26
=========================================
+ Hits 100250 100271 +21
- Misses 21045 21050 +5 |
|
|
Looks like I should move this higher still. Startup metrics are likely different than steady state metrics. |
jeffwashington
force-pushed
the
65k2
branch
3 times, most recently
from
1d1e7af to
1b9a485
Compare
jeffwashington
commented
Jun 14, 2021
ledger-tool/src/main.rs
Outdated
| let mut drop_time = Measure::start("drop_time"); | ||
| drop(bank_forks); | ||
| drop_time.stop(); | ||
| info!("drop(bank_forks): {}us", drop_time.as_us()); |
There was a problem hiding this comment.
This drop coincides with a long delay after ledger-tool verify is finished. Reporting this will help the next person verify that this portion of the validator code path is capturing time correctly. Without the explicit drop, the time is when bank_forks goes out of scope and is dropped.
jeffwashington
force-pushed
the
65k2
branch
2 times, most recently
from
7ac25d6 to
bc68657
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jun 15, 2021
* add metrics for startup * roll timings up higher * fix test * fix duplicate (cherry picked from commit 471b341) # Conflicts: # ledger/src/bank_forks_utils.rs # runtime/src/snapshot_utils.rs
jeffwashington
added a commit
that referenced
this pull request
Jun 15, 2021
mergify bot
added a commit
that referenced
this pull request
Jun 16, 2021
* add metrics for startup
* roll timings up higher
* fix test
* fix duplicate
(cherry picked from commit 471b341)
# Conflicts:
# ledger/src/bank_forks_utils.rs
# runtime/src/snapshot_utils.rs
conflicts because #17778 is not present.
Co-authored-by: Jeff Washington (jwash) <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A goal is to speedup startup time of validator. Would be nice to have metrics over more parts.
Summary of Changes
Add metric for the major parts of preparing to start. This at least excludes snapshot download, gossip work, and initial replay.
Fixes #