This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
add metrics to handle_snapshot_requests #17937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lemond, against current mnb snapshot |
sakridge
reviewed
Jun 14, 2021
| ) -> Option<u64> { | ||
| self.snapshot_request_receiver | ||
| .try_iter() | ||
| .last() | ||
| .map(|snapshot_request| { | ||
| let mut total_time = Measure::start("wallclock time elapsed"); |
There was a problem hiding this comment.
would be nice if this mentions something about snapshots. With nvtx labels "wallclock time elapsed" won't be very descriptive.
There was a problem hiding this comment.
will handle in separate pr
sakridge
approved these changes
Jun 14, 2021
Codecov Report
@@ Coverage Diff @@
## master #17937 +/- ##
=======================================
Coverage 82.6% 82.6%
=======================================
Files 431 431
Lines 121288 121302 +14
=======================================
+ Hits 100224 100250 +26
+ Misses 21064 21052 -12 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 14, 2021
(cherry picked from commit e6bbd4b)
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Jun 14, 2021
mergify bot
added a commit
that referenced
this pull request
Jun 14, 2021
(cherry picked from commit e6bbd4b) Co-authored-by: Jeff Washington (jwash) <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As # accounts grows, handle_snapshot_requests code path execution time grows very large. Having metrics of the total processing time and idle time will help find and verify improvements. For example, if clean and hash calculation can be performed in parallel, then overall time could improve while individual times (hash & clean) could get worse.
Summary of Changes
add metrics
Fixes #