This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
refactor so hash verify can be done by more callers #17941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17941 +/- ##
=========================================
Coverage ? 82.6%
=========================================
Files ? 431
Lines ? 121295
Branches ? 0
=========================================
Hits ? 100239
Misses ? 21056
Partials ? 0 |
jbiseda
approved these changes
Jun 14, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jun 14, 2021
(cherry picked from commit 62e1b20) # Conflicts: # runtime/src/accounts_db.rs
jeffwashington
added a commit
that referenced
this pull request
Jun 15, 2021
mergify bot
added a commit
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Jeff Washington (jwash) <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The ability to calculate the hash while verifying index and non-index versions is useful outside of the current code path that only supports this while updating the hash.
Summary of Changes
extract code to make a sub-function
Fixes #