This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
avoid unnecessary empty arrays when binning #17944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
range
branch
3 times, most recently
from
2ceb09a to
39e95a3
Compare
Codecov Report
@@ Coverage Diff @@
## master #17944 +/- ##
=========================================
Coverage ? 82.6%
=========================================
Files ? 431
Lines ? 121318
Branches ? 0
=========================================
Hits ? 100262
Misses ? 21056
Partials ? 0 |
sakridge
approved these changes
Jun 16, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jun 16, 2021
(cherry picked from commit eee5414)
mergify bot
added a commit
that referenced
this pull request
Jun 16, 2021
(cherry picked from commit eee5414) Co-authored-by: Jeff Washington (jwash) <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We can scan storages in bins to reduce dynamic memory usage. We store account info by bin.
Summary of Changes
Compact the bin arrays we use to only use the range of bins for this pass instead of all bins. This reduces memory use and useless iterating over empty array elements.
Fixes #