This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
remove unused parameters from CalculateHashIntermediate #17949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17949 +/- ##
=========================================
Coverage ? 82.6%
=========================================
Files ? 431
Lines ? 121301
Branches ? 0
=========================================
Hits ? 100235
Misses ? 21066
Partials ? 0 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 15, 2021
(cherry picked from commit 4d8ffdc)
mergify bot
added a commit
that referenced
this pull request
Jun 15, 2021
) (cherry picked from commit 4d8ffdc) Co-authored-by: Jeff Washington (jwash) <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CalculateHashIntermediate has been refactored to not use slot or write version. The old constructor was left in place so tests didn't noisly change yet.
Summary of Changes
Get rid of unused parameters on the tests.
Fixes #