This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
generate_index timings #17983
Merged
generate_index timings #17983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17983 +/- ##
=======================================
Coverage 82.6% 82.6%
=======================================
Files 435 435
Lines 121576 121580 +4
=======================================
+ Hits 100468 100481 +13
+ Misses 21108 21099 -9 |
jbiseda
approved these changes
Jun 17, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2021
(cherry picked from commit 1feaaf0)
jeffwashington
added a commit
that referenced
this pull request
Jun 17, 2021
(cherry picked from commit 1feaaf0)
jeffwashington
added a commit
that referenced
this pull request
Jun 17, 2021
(cherry picked from commit 1feaaf0)
jeffwashington
added a commit
that referenced
this pull request
Jun 21, 2021
(cherry picked from commit 1feaaf0) Co-authored-by: Jeff Washington (jwash) <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are about to rework and pipeline generate_index with other stages of startup.
Summary of Changes
separate timings for generate_index into its own struct, like other places we capture timings.
Fixes #